New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid semantics of register access in `vinsert` instruction #182

Closed
marekjm opened this Issue Aug 21, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@marekjm
Copy link
Owner

marekjm commented Aug 21, 2017

As reported by @vktgz the semantics of register access by the last operand of the vinsert instruction are invalid.

Current (buggy) behaviour: if last operand accesses registers in the register-indirect mode it behaves as if plain mode was used, if plain mode is used the register index is treated as a literal integer.

Expected behaviour: index operand has the usual semantics for register-indirect and plain register access modes.

This behaviour is a result of the fact that in the beginning the last operand was a literal integer. But due to the move away from literals in non-constructor instructions, that has changed, but the change was badly implemented.

@marekjm

This comment has been minimized.

Copy link
Owner Author

marekjm commented Aug 21, 2017

Fixed by 2554549.

@marekjm marekjm closed this Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment