Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Mark error handler as called for closed sessions
When a DCB error occurs, the handleError entry point of the routers is
called. The caller of this entry point expects that the error handler
marks the DCB as handled. The aforementioned behavior is wrong as the
error handler should not keep track of whether the handler was already
called.
  • Loading branch information
markus456 committed Dec 11, 2016
1 parent d4d40c0 commit 15a8675
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions server/modules/routing/readwritesplit/readwritesplit.c
Expand Up @@ -4439,6 +4439,7 @@ static void handleError(ROUTER *instance, void *router_session,
if (!rses_begin_locked_router_action(rses))
{
/** Session is already closed */
problem_dcb->dcb_errhandle_called = true;
*succp = false;
return;
}
Expand Down

0 comments on commit 15a8675

Please sign in to comment.