MXS-3282: Select query inside transactions are routed to slave with s… #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession_track_trx_state=true
if (trx_state.find_first_of("TI") == std::string::npos) is the reverse of what we want.
If neither T and I are set, we set our trx state to SESSION_TRX_ACTIVE.
This should be If either T or I is set, our trx_state is SESSION_TRX_ACTIVE
markus456
approved these changes
Nov 5, 2020
jhnwkmn
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ession_track_trx_state=true
if (trx_state.find_first_of("TI") == std::string::npos) is the reverse of what we want.
If neither T and I are set, we set our trx state to SESSION_TRX_ACTIVE.
This should be If either T or I is set, our trx_state is SESSION_TRX_ACTIVE
I am contributing the new code of the whole pull request, including one or
several files that are either new files or modified ones, under the BSD-new
license.