Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mysql8.0.x #230

Merged
merged 1 commit into from Jul 14, 2021
Merged

support mysql8.0.x #230

merged 1 commit into from Jul 14, 2021

Conversation

HappyUncle
Copy link

support 8.0.x

@markus456
Copy link
Contributor

This should be done in a more controllable manner so that you can use MySQL connectors with MariaDB. Adding it as a configuration parameter would allow it to be enabled and disabled. Another option might be to see if there's a way to detect that the client doesn't expect the 5.5.5- prefix and drop it only for those clients.

@HappyUncle
Copy link
Author

Thank you for your reply. Later I will change it as configuration parameter, so that can control it.

@markus456
Copy link
Contributor

I think I have to apologize: I misunderstood which version_string this change affected. I thought it was for the one returned by the backend servers themselves that MaxScale uses by default but instead it is for the version_string parameter defined in the configuration file.

Now that I've taken a second look at this, I think just the original commit would be adequate as the new parameter doesn't seem to do that much.

@markus456
Copy link
Contributor

Additionally, we require that any code contributions to MaxScale are submitted under the BSD-new license. Please indicate this by leaving a comment with the following text:

I am contributing the new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license.

@HappyUncle
Copy link
Author

I am contributing the new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license.

Copy link
Contributor

@markus456 markus456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that the original commit that only checks whether the version_string starts with an 8 would have been enough. Can you use that commit?

@HappyUncle
Copy link
Author

Ok, I've revised it.

@markus456 markus456 merged commit 286f446 into mariadb-corporation:2.5 Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants