Dont remove maxscale binary when stopping via init.d #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of nonexistent $PIDFILE variagle binary was removed when stopping MaxScale. Delete this line as maxscale will be stopped by maxscale_wait_stop
Because of nonexistent $PIDFILE variagle binary was removed when stopping MaxScale. Delete this line as maxscale will be stopped by maxscale_wait_stop
|
Sorry for the double commit but had to do this via GitHub UI. Nice surprise when evaluating MaxScale. 💥 |
zytek
changed the title
|
Nice find... |
|
Ouch, I see this was reported 4 months ago... 👎 |
|
Closing, bug is fixed |
|
@markus456 I still see offending $PIDFILE variable in the repo, could you elaborate how it was fixed ? It works fine on Ubuntu Trusty, but removes binary on Ubuntu Precise |
|
It is fixed in the next release (the develop branch). |
|
This wouldn't be a problem if you properly-quoted the variable expansions. You should always quote variable expansions in shell. So, this should be: killproc -p "$PIDFILE" "$DAEMON" |
liangg
added a commit
to airbnb/MaxScale
that referenced
this pull request
Oct 13, 2016
…server_stats_json_fix [DBProxy] Fix server stats export json format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.