MCOL-1578 - PDI plugin Windows port #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sneJ-
commented
Jul 28, 2018
sneJ-
commented
- Ported the PDI plugin to Windows
- Ported PDI's test pipeline to Windows
- Adapted the build pipeline accordingly
- Added instructions to the documentation
- Tested on Windows 10 and CentOS 7
davidwbt
suggested changes
Aug 29, 2018
| String jar = new URI(KettleColumnStoreBulkExporterStepMeta.class.getProtectionDomain().getCodeSource().getLocation().toString().replace(" ", "%20")).getPath(); | ||
| System.err.println(jar); | ||
| String jarPath = jar.substring(0, jar.lastIndexOf("/")); | ||
| if(System.getProperty("os.name").indexOf("nux") >= 0){ |
There was a problem hiding this comment.
I think it would be safer to invert the logic here and make it if then .. else .. (implied unix default).
.../src/main/java/com/mariadb/columnstore/api/kettle/KettleColumnStoreBulkExporterStepMeta.java
Show resolved
Hide resolved
davidwbt
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.