MCOL-303 #12
Merged
MCOL-303 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Between 1.0.1 and 1.0.2 there were chnages to the build system which allow for different build options with CMake. Unfortunately the default was not set correctly so the default build was not optimised. This change allows for the default build to be optimised again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out if CMAKE_BUILD_TYPE is not already set the 'SET' command doesn't apply to the cache. This meant that CMAKE_BUILD_TYPE was not set by default and therefore no compiler flags were set.
With no compiler flags set we were using unoptimised builds which caused large performance regressions.
This fix tells CMAKE to set the default build to Release With Debug Info as intended but allows the user to change this.