cmake fixes #1243
Merged
cmake fixes #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip building the plugin instead
1. reduce the number of cmake warnings 2. remove unused OLD policies 3. only warn about missing prerequisites once 4. start cmake output from columnstore version
pleblanc1976
reviewed
Jun 1, 2020
| endif() | ||
| endif() | ||
| endif() | ||
|
|
There was a problem hiding this comment.
I don't see a replacement for this block of code in the new version. Is submodule pulling a manual step in the community server?
There was a problem hiding this comment.
No, it's done by cmake/submodules.cmake for all submodules, so your separate git submodule update is redundant.
the server has, like, seven (?) submodules now, and after the second submodule we've figured out that if all submodules will need this auto-updating code, we can as well put it in the server and spare submodules some troubles and avoid some copy-pasting
pleblanc1976
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't FATAL_ERROR if prerequisites are not found, skip building the plugin instead
and cmake output cleanup: