MCOL-4117: Clean away unnecessary USE_CCACHE build flag #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systems with ccache will have gcc/g++ automatically wrapped by ccache and there is no need inject 'ccache' into the build command like this. No other part of the MariaDB Server nor in general other software have any USE_CCACHE practice. To all of them ccache works transparently, and extra code like this is unnecessay and just plain confusing. This commit does not yet close MCOL-4117, but is a step forward in making the code base compatible with using ccache in build systems in general.
pleblanc1976
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systems with ccache will have gcc/g++ automatically wrapped by ccache
and there is no need inject 'ccache' into the build command like this.
No other part of the MariaDB Server nor in general other software have
any USE_CCACHE practice. To all of them ccache works transparently, and
extra code like this is unnecessay and just plain confusing.
This commit does not yet close MCOL-4117, but is a step forward in making
the code base compatible with using ccache in build systems in general.