Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCOL-4124 return error when COMMIT|ROLLBACK error #1316

Merged
merged 2 commits into from Jun 30, 2020
Merged

MCOL-4124 return error when COMMIT|ROLLBACK error #1316

merged 2 commits into from Jun 30, 2020

Conversation

davidhall586
Copy link
Contributor

No description provided.

@pleblanc1976 pleblanc1976 merged commit 9675439 into mariadb-corporation:develop Jun 30, 2020
@tntnatbry
Copy link
Contributor

@dhall-MariaDB

On line 520 in this file, I see the following:

        rc = ProcessCommandStatement ( thd, command, ci, schema );
        rc = ci.rc;

If ProcessCommandStatement returns a non-zero value and ci.rc=0, then we incorrectly set rc to 0.

@tntnatbry
Copy link
Contributor

Also, I see one issue with the usage of rc = max(rc, rc1); if either of the two values is less than 0 (error) and the other is 0, then we incorrectly set rc to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants