Refactor better extent info bookkeeping structure and handling #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drrtuy
reviewed
Nov 30, 2020
drrtuy
reviewed
Nov 30, 2020
mariadb-SergeyZefirov
force-pushed
the
MCOL-2044-refactoring
branch
2 times, most recently
from
cc9dbf7
to
3a0b974
Compare
tntnatbry
previously requested changes
Dec 1, 2020
mariadb-SergeyZefirov
force-pushed
the
MCOL-2044-refactoring
branch
from
3a0b974
to
02b71f9
Compare
Logs for research purposes Keep progress - may not build Good interface to collect LBIDs and CPInfo's Write Engine compiles with new interface New interface breaks things the least way and allows for new features to be added gradually. Still ironing design - rewriting parts of WE Keep progress commit Write Engine compiles, going to test I could introduce crashes there. Let's see. Disable logging for tests Fixing build problems - keep progress commit Changed related to new interface Add back accidentally removed m_txnLBIDMap.find Remove printf/cout; up-to-date comment for AddLBIDtoList Add "auto" type annotation Work on PR comments Descriptive vector emptines check
mariadb-SergeyZefirov
force-pushed
the
MCOL-2044-refactoring
branch
from
02b71f9
to
2bfe9b6
Compare
drrtuy
approved these changes
Dec 8, 2020
drrtuy
dismissed
tntnatbry’s stale review
All suggestions were either implemented or rejected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code below makes, in my opinion, better structure for handling bookkeeping of extents and their ranges.
Right now the bookkeeping is for marking extents as invalid, nothing more.