Fixes MCOL-4511 and MCOL-4524 #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
long double is 128 bit on aarch64, even if it is soft supported, not hardware instrunction supported. So, here we just use long double on aarch64.
On aarch64, just use memcpy, don't use asm instructions to optimize it. Because if gcc uses NEON extensions moving 16 bytes with memcpy, it might be wise to just use memcpy instead
|
The failed MTR test contains a mistake in the reference file. |
drrtuy
approved these changes
Jan 30, 2021
|
@zhaorenhai Could you confirm that you contribute this under BSL? |
|
Yes, I can confirm |
|
Sorry, Roman, 'The failed MTR test contains a mistake in the reference file.' |
|
No, it doesn't at all.
Thank you for the contribution!
вс, 31 янв. 2021 г., 4:20 zhaorenhai <notifications@github.com>:
… Sorry, Roman, 'The failed MTR test contains a mistake in the reference
file.'
Is it related with my commits?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1744 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC3JDLGVDFL64HZ2AZL4R53S4SV4NANCNFSM4W2CZVRQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.