MCOL-4741 Fix extentmap handling of string prefixes encoded as 64-bit integers #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relevant task: https://jira.mariadb.org/browse/MCOL-4741 |
|
@mariadb-SergeyZefirov Code changes look good to me. However, we are missing test case for this. In https://jira.mariadb.org/browse/MCOL-4741 you have mentioned you were able to come up with a small reproducible test case. Can you please add it to MTR under mysql-test/columnstore/bugfixes ? Also, once all changes are pushed, please also fix the original commit message. Right now, it contains some garbage text. As standard practice, we start the commit message with the MCOL number followed by the message. As reference, you can take a look at the existing commit history here: https://github.com/mariadb-corporation/mariadb-columnstore-engine/commits/develop |
This is due to signedness in the string range comparison in extentmap and unsignedness everywhere else.
mariadb-SergeyZefirov
force-pushed
the
MCOL-4741-in-like-equal-returns-different-result
branch
from
4f08f82
to
c58136a
Compare
tntnatbry
changed the title
tntnatbry
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It so happened that string prefixes, encoded as integers for comparison, were compared in range merge operation (used primarily by cpimport) as signed integers, not unsigned ones (as memcmp/strcmp would).
This was the main reason of range values became messed up after cpimport of completely NULL column.