Make date handling more in-line with MySQL #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date limit of year 1400 was used due to Boost's limits. This patch strips out the use of Boost for date handling and sets the lower limit to year 1000.
LinuxJedi
added a commit
to LinuxJedi/mariadb-columnstore-engine
that referenced
this pull request
Feb 6, 2020
When ALTER TABLE ... ENGINE= is called the following happens: 1. A temporary table is created in the new engine with the real table name but a temporary file name supplied 2. A bulk insert is started from old to new table 3. The old table is dropped 4. The new table is renamed For mariadb-corporation#1 we use the real table name instead of the temporary file name (otherwise step mariadb-corporation#2 breaks), we were therefore trying to skip mariadb-corporation#4. This broke regular RENAME TABLE commands. With this patch we detect if the rename is for a temporary to real table and skip it. Since this is the only instance where we support temporary tables. This patch also fixes issues with extracting table names from file names and some other irrelevant stuff. Longer term if we want to support temporary tables we need to store the provided filename in our metadata since it could be different from table name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date limit of year 1400 was used due to Boost's limits.
This patch strips out the use of Boost for date handling and sets the
lower limit to year 1000.