Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unneeded k for loop #746

Merged
merged 2 commits into from May 2, 2019
Merged

unneeded k for loop #746

merged 2 commits into from May 2, 2019

Conversation

gscteam
Copy link
Contributor

@gscteam gscteam commented May 1, 2019

Hotsport identified in perf top, It seems that the k-loop is not needed there.

@drrtuy
Copy link
Collaborator

drrtuy commented May 1, 2019

Agree, this loop could be avoided. Could you post license-mantra?

@gscteam
Copy link
Contributor Author

gscteam commented May 1, 2019

Submitted under the BSD license.

@LinuxJedi LinuxJedi merged commit 72c126f into mariadb-corporation:develop-1.2 May 2, 2019
@gscteam
Copy link
Contributor Author

gscteam commented May 8, 2019

There is one condition that might be missing, if columnsUpdated.size() is 0, then nothing get done. It is unclear for me when would that be the case, since the j loop for (unsigned int j = 0; j < columnsUpdated.size(); j++) is also based on that. So if that size is 0 it would not even reach that far.

@drrtuy
Copy link
Collaborator

drrtuy commented May 9, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants