Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCOL-3645 - Make ExeMgr destroy joblists in a different thread #958

Merged
merged 4 commits into from Dec 4, 2019
Merged

MCOL-3645 - Make ExeMgr destroy joblists in a different thread #958

merged 4 commits into from Dec 4, 2019

Conversation

pleblanc1976
Copy link
Contributor

Prevents joblist destruction from stalling the main session thread by putting destruction in a different thread. Will improve user exp when running queries that use a lot of mem, and/or when running queries in a script.

exemgr/main.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@jmrojas2332 jmrojas2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only issue I see is the static msgLog being passed into lambda which causes a warning. See my line comment.

@jmrojas2332 jmrojas2332 merged commit 72b78ca into mariadb-corporation:develop Dec 4, 2019
@pleblanc1976 pleblanc1976 deleted the threaded-jl-dtor branch October 26, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants