Improve Debian package versioning #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value left in the variable.
… round(tan(0)) -- cause the thd->is_error flag set. This in turn suppresses the call of rnd_end, which leaves garbage for the next query. Call rnd_end in this situation.
RPM workaround not needed in debian packages
MCOL-470 Merge MariaDB 10.1.20
Update README.md
MCOL-506 for 1.1
…e-processing. Don't just throw it away for a mem leak.
MCOL-550 delete the result object from lex that we don't need from pr…
MCOL-562 Fix Debian package dependencies
Though it manages both `CPACK_DEBIAN_PACKAGE_VERSION` and `CPACK_DEBIAN_PACKAGE_RELEASE` variables, CPack only use first one to build Debian package.
This lead to have a version number without any release indication.
The patch aims to set `CPACK_DEBIAN_PACKAGE_VERSION` with both `PACKAGE_VERSION`, `PACKAGE_RELEASE`.
Adding `DEB` variable to `CPACK_DEBIAN_PACKAGE_VERSION` allows to include distribution name in version.
This is mandatory when using a Debian repository managed by `reprepro`, which only allows one package file per version.
So, you can't have `mariadb-columnstore-client` package for both `jessie` & `stretch` with version `1.0.7`
Packages can be built with command:
cmake . -DCMAKE_INSTALL_PREFIX=/usr/local/mariadb/columnstore/mysql -DDEB=jessie
make -j4 package
Resulting packages will have version `1.0.7-1~jessie` instead of `1.0.7`.
Please beware that this patch also might break your CI because package filename is modified.
jbfavre
changed the title
|
Created MCOL-565 for this and assigned to Ben to review: https://jira.mariadb.org/browse/MCOL-565 |
polobandit
approved these changes
Jun 5, 2018
|
The mariadb-columnstore-server tree is now deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though it manages both
CPACK_DEBIAN_PACKAGE_VERSIONandCPACK_DEBIAN_PACKAGE_RELEASEvariables, CPack only use first one to build Debian package.This lead to have a version number without any release indication.
The patch aims to set
CPACK_DEBIAN_PACKAGE_VERSIONwith bothPACKAGE_VERSIONandPACKAGE_RELEASEvariables.Adding
DEBvariable toCPACK_DEBIAN_PACKAGE_VERSIONallows to add distribution name in version.This is mandatory when using a Debian repository managed by
reprepro, which only allows one package file per version.As an example, you can't have
mariadb-columnstore-clientpackage for bothjessie&stretchwith version1.0.7because package are likely to have different checksums.Packages can be built with command:
Resulting packages will have version
1.0.7-1~jessieinstead of1.0.7.Please beware that this patch also might break your CI because package filename is modified.