MCOL-2089 - pipelining for mcsimport #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first draft of multi-threaded implementation still slower than single threaded mostly due to blocking data-structures and mutexes all tests passed on Windows 10
internal datastructure changed to two ring buffers to avoid locking performance gain in load_test_2 compared to 1.2.2 around 20% test suite passed on Windows 10 against a remote CS 1.2 on CentOS 7
- added comments - tests on Windows 10 passed
to let buildbot benchmark the optimized version against the non-optimized version on supported Linux operating systems
|
closed in favour of PR34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made mcsimport multi threaded.
One thread reads the csv file, one file parses it into csv fields, and one thread writes the csv fields to CS.
They communicate through 2 FiFo queues implemented utilizing ring buffers.
Performance gain is around 25% compared to the single threaded 1.2.2 implementation of mcsimport.
Used the test suite's load_test_2 (1.2GiB CSV file) as reference.
On the downside of using more threads and buffers the implementation now consumes around 10 times more RAM and 1.5 times more CPU cycles.
Test suite successfully executed on Windows 10 against a remote CS 1.2.2-1 instance on CentOS 7.