From 058fc080b4ee95bce405c182ae8d542576863f8a Mon Sep 17 00:00:00 2001 From: Georg Richter Date: Fri, 26 Jan 2018 13:04:37 +0100 Subject: [PATCH] Fixed 2 buffer overflows in unittests --- unittest/libmariadb/dyncol.c | 4 ---- unittest/libmariadb/errors.c | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/unittest/libmariadb/dyncol.c b/unittest/libmariadb/dyncol.c index 13b562f7a..6e7e9913b 100644 --- a/unittest/libmariadb/dyncol.c +++ b/unittest/libmariadb/dyncol.c @@ -153,10 +153,6 @@ static int create_dyncol_num(MYSQL *mysql) rc= mariadb_dyncol_unpack(&dyncol, &my_count, &my_keys, &my_vals); diag("unpack: %d %d", rc, my_count); - for(i=0; i < 5; i++) - { - diag("%s %lu", my_keys[i].str, (unsigned long)my_keys[i].length); - } free(my_keys); free(my_vals); diff --git a/unittest/libmariadb/errors.c b/unittest/libmariadb/errors.c index fbad15327..3aa463695 100644 --- a/unittest/libmariadb/errors.c +++ b/unittest/libmariadb/errors.c @@ -242,7 +242,7 @@ static int test_parse_error_and_bad_length(MYSQL *mysql) rc= mysql_query(mysql, "SHOW DATABAAAA"); FAIL_UNLESS(rc, "Error expected"); - rc= mysql_real_query(mysql, "SHOW DATABASES", 100); + rc= mysql_real_query(mysql, "SHOW DATABASES\0AAA", 18); FAIL_UNLESS(rc, "Error expected"); stmt= mysql_stmt_init(mysql);