Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fix syntax error in cmake 3.20
  • Loading branch information
@vaintroub
vaintroub committed Mar 11, 2021
1 parent 15471ce commit 242cab8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmake/ConnectorName.cmake
View file
Expand Up @@ -22,7 +22,7 @@ IF(CMAKE_SYSTEM_NAME MATCHES "Windows")
SET(MACHINE_NAME "x64")
ELSE()
SET(MACHINE_NAME "32")
END()
ENDIF()
ENDIF()

SET(product_name "mysql-connector-c-${CPACK_PACKAGE_VERSION}-${PLATFORM_NAME}${CONCAT_SIGN}${MACHINE_NAME}")
Expand Down

3 comments on commit 242cab8

@NicklasWallgren
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaintroub Hey, why is this bug still present in https://downloads.mariadb.com/MariaDB/mariadb-10.5.9/source/?

@vuvova
Copy link
Member

@vuvova vuvova commented on 242cab8 Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because https://github.com/MariaDB/server/tree/mariadb-10.5.9, if you follow links from there, uses mariadb-connector-c as of v3.1.12

@NicklasWallgren
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vuvova Thanks for the response.

We're really in a hard spot.
We cannot install 10.5.9 due to this issue, and we cannot install 10.5.10 due to an issue in brew, and 10.5.11+ introduced this bug https://jira.mariadb.org/browse/MDEV-26123.

We'll have to manually patch 10.5.9 until https://jira.mariadb.org/browse/MDEV-26123 is fixed.

Please sign in to comment.