Fix for cleartext plugin: We need to send also terminating zero character for password

9EOR9 · 9EOR9 · commit ed9df19f58ca · 2014-12-11T11:20:32.000+01:00
diff --git a/plugins/auth/mariadb_cleartext.c b/plugins/auth/mariadb_cleartext.c
@@ -47,7 +47,8 @@ static int clear_password_auth_client(MYSQL_PLUGIN_VIO *vio, MYSQL *mysql)
   if (!vio || !mysql || !mysql->passwd)
     return CR_ERROR;
 
-  return vio->write_packet(vio, (const unsigned char *) mysql->passwd, strlen(mysql->passwd)) ?
+  /* write password including terminating zero character */
+  return vio->write_packet(vio, (const unsigned char *) mysql->passwd, strlen(mysql->passwd) + 1) ?
          CR_ERROR : CR_OK;
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,8 @@ static int clear_password_auth_client(MYSQL_PLUGIN_VIO vio, MYSQL mysql)`
`47`	`47`	`if (!vio \|\| !mysql \|\| !mysql->passwd)`
`48`	`48`	`return CR_ERROR;`
`49`	`49`
`50`		`- return vio->write_packet(vio, (const unsigned char *) mysql->passwd, strlen(mysql->passwd)) ?`
	`50`	`+ /* write password including terminating zero character */`
	`51`	`+ return vio->write_packet(vio, (const unsigned char *) mysql->passwd, strlen(mysql->passwd) + 1) ?`
`51`	`52`	`CR_ERROR : CR_OK;`
`52`	`53`	`}`
`53`	`54`	`/* }}} */`