Fix string conversion of timestamps containing microseconds #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ps_fetch_datetime() does not work for DATETIME(n) fields where n is between 1 and 5.
for example, when DATETIME(3) is used for millisecond resolution, the current version sprintf()s the first 3 digits of the microsecond field, but this yields a wrong output, when there are leading zeroes (see examples below).
Test values, type DATETIME(3):
2016-03-09 07:51:49.000
2016-03-09 07:51:49.001
2016-03-09 07:51:49.010
ps_fetch_datetime() output:
2016-03-09 07:51:49
2016-03-09 07:51:49.1000
2016-03-09 07:51:49.10000