CONC-553: Fix SIGBUS when calling mysql_real_connect_start on ARM64 macOS #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acOS Co-authored-by: LoveSy <shana@zju.edu.cn>
vuvova
reviewed
Jun 17, 2021
| @@ -4,6 +4,9 @@ INCLUDE_DIRECTORIES(${CC_SOURCE_DIR}/include | |||
| ADD_DEFINITIONS(-D HAVE_COMPRESS) | |||
| ADD_DEFINITIONS(-D LIBMARIADB) | |||
| ADD_DEFINITIONS(-D THREAD) | |||
| IF(APPLE) | |||
| ADD_DEFINITIONS(-D _XOPEN_SOURCE) | |||
There was a problem hiding this comment.
shouldn't it be _XOPEN_SOURCE=600 ?
There was a problem hiding this comment.
I have no idea why it was 600 as I checked ucontext.h:
#ifdef _XOPEN_SOURCE
...
#else /* !_XOPEN_SOURCE */
#error The deprecated ucontext routines require _XOPEN_SOURCE to be defined
#endif /* _XOPEN_SOURCE */
Also it seems it was producing compilation errors if I set _XOPEN_SOURCE to 600. Setting -D _XOPEN_SOURCE just works fine.
|
CI seems passing now. |
|
@vuvova This is really necessary for M1 working when creating MySQL Client through code, and I confirm it's working perfectly with this simple changes. |
|
Manually merged into 3.1 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this stack overflow question
So I moved the
_XOPEN_SOURCEmacro toCMakefile.txt.