CONC-283: Install libmariadb.pc

[candrews]

Thanks to astavale astavale@yahoo.co.uk and tabata shintaro

https://jira.mariadb.org/browse/CONC-283

[9EOR9]

This was already fixed in 3.0.7

[Whissi]

@9E0R9 But your solution is wrong: 3.0.7 will set

Libs: -L${libdir} -lmariadb -lz -ldl -lm -lpthread -lgnutls

but "Libs" should only list what is required to link against libmariadb. Things like -lz -ldl -lm -lpthread -lgnutls can be listed in "Libs.private" but exposing in Libs is wrong.

[Whissi]

Proposed fix:

--- a/mariadb_config/libmariadb.pc.in
+++ b/mariadb_config/libmariadb.pc.in
@@ -7,13 +7,12 @@
 #

 prefix=@CMAKE_INSTALL_PREFIX@
-includedir=${prefix}/@INSTALL_INCLUDEDIR@/@SUFFIX_INSTALL_DIR@
-libdir=${prefix}/@INSTALL_LIBDIR@/@SUFFIX_INSTALL_DIR@
+includedir=${prefix}/include
+libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@

 Name: libmariadb
 Version: @CPACK_PACKAGE_VERSION@
+URL: https://mariadb.com/kb/en/library/mariadb-connector-c/
 Description: MariaDB Connector/C dynamic library
-Cflags: -I${includedir}
-Libs: -L${libdir} -lmariadb @extra_dynamic_LDFLAGS@
-
-
+Cflags: -I${includedir}/mariadb
+Libs: -L${libdir} -lmariadb

[9E0R9]

Hi Thomas, Changing this will most likely break any project which uses mariadb_config. /Georg Am So., 2. Dez. 2018, 23:48 hat Thomas Deutschmann <notifications@github.com> geschrieben:

…

@9E0R9 <https://github.com/9E0R9> But your solution is wrong: 3.0.7 will set Libs: -L${libdir} -lmariadb -lz -ldl -lm -lpthread -lgnutls but "Libs" should only list what is required to link against *libmariadb*. Things like -lz -ldl -lm -lpthread -lgnutls can be listed in "Libs.private" but exposing in *Libs* is wrong. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#72 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHXTvjpNMxAxB2cr7PNLe6xWHYT0lb3Lks5u1FjAgaJpZM4XcqLL> .