Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONJ-525 Fix for having extra update count during batch queries, with… #112

Merged
merged 2 commits into from Sep 24, 2017

Conversation

yerenkow
Copy link

… -3 which is unexpected by external consumers

… -3 which is unexpected by external consumers
@yerenkow
Copy link
Author

Travis was fine for this commit
https://travis-ci.org/yerenkow/mariadb-connector-j/builds/275886739

I have no idea why appveyor has failed :)

@rusher
Copy link
Collaborator

rusher commented Sep 20, 2017

Hi @yerenkow,

Correction will be in next version.

Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license. (The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/)

Please indicate in a comment below that you are contributing your new code of the whole pull request under the BSD-new license or that you have filled out the contribution agreement and sent it.

Thanks,
diego

*/
@Override
public void clearErrorStat() {
hasException = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverting must then set hasException to false

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, of course this should be set to false!

@yerenkow
Copy link
Author

I'm contributing new code and changes of the whole pull request under the BSD-new license.
Feel free to use it or rewrite at your convenience.

Thanks.

@rusher rusher merged commit 755d162 into mariadb-corporation:master Sep 24, 2017
@yerenkow yerenkow deleted the CONJ-525 branch September 25, 2017 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants