Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONJ-564] Never ever throw an instance of java.lang.Error #119

Merged
merged 1 commit into from Feb 20, 2018

Conversation

wglas85
Copy link
Contributor

@wglas85 wglas85 commented Jan 1, 2018

Replace Exceptions based on java.lang.Error by likewise java.lang.RuntimeException replacements.

@wglas85
Copy link
Contributor Author

wglas85 commented Jan 2, 2018

Hi johnou, thanks for accepting this pull request, should we then close the issue https://jira.mariadb.org/browse/CONJ-564 ?

@johnou
Copy link

johnou commented Jan 2, 2018

@wglas85 All I did was review the changes, I didn't accept the pull request nor can I (I am not a maintainer).

@rusher
Copy link
Collaborator

rusher commented Jan 23, 2018

Hi @wglas85,

The correction will be in next version.

Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license. (The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/)

Please indicate in a comment below that you are contributing your new code of the whole pull request under the BSD-new license or that you have filled out the contribution agreement and sent it.

Thanks,
diego

@wglas85
Copy link
Contributor Author

wglas85 commented Jan 23, 2018

Hello @rusher,

For sure I provide my fix under the BSD-new license.

Best regards, Wolfgang Glas

@rusher rusher merged commit 3bbadbd into mariadb-corporation:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants