Take maxFieldSize only if length is larger. #121
Conversation
The logic for enforcing maxFieldSize was highly obviously wrong; one should take the smaller of maximum size and actual size, not the larger.
The logic for enforcing maxFieldSize was highly obviously wrong; one should take the smaller of maximum size and actual size, not the larger.
Take maxFieldSize only if length is larger
|
Hi @arthurvl, Thanks for your contribution! Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license. The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/ Please indicate in a comment below that you are contributing your new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license or that you have filled out the contribution agreement and sent it. Thanks, |
|
Hi @rusher, ofcourse, this is something I should have realized :). All new and modified code in this pullrequest is hereby placed under the 3-clause BSD license, as may be found under https://opensource.org/licenses/BSD-3-Clause, and marked as Copyright 2018 Nedap B.V. It is our definite intention that this code will become part of the MariaDB Connector/J source code and that MariaDB gains rights to distribute and maintain it. With kind regards, Arthur van Leeuwen. |
Enforcing maxFieldSize in BinaryRowProtocol and TextRowProtocol is quite obviously broken. This pull request fixes the brokenness.