NPE fix if url used like: jdbc:mariadb://localhost/testj?user=root&maxPoolSize=10 #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//Sample Program to create NullPointerException:
public class ConnectionUsingDS {
public static void main(String args[]) throws SQLException {
MariaDbPoolDataSource pool =
new MariaDbPoolDataSource("jdbc:mariadb://localhost/testj?user=root&maxPoolSize=10");
try (Connection conn = pool.getConnection()) {
try(Statement stmt = conn.createStatement()){
ResultSet rs = stmt.executeQuery("select 'Hello World!'");
while(rs.next()){
System.out.println(rs.getString(1));
}
System.out.println(pool.getDatabaseName() +", "+pool.getPort());
}
}
}
//Output:
//Hello World!
//Exception in thread "main" java.lang.NullPointerException
// at org.mariadb.jdbc.MariaDbPoolDataSource.getPort(MariaDbPoolDataSource.java:153)
// at mariadb.test.connection.ConnectionUsingDS.main(ConnectionUsingDS.java:32)