[OSGi] Support the Data Service Specification for JDBC™ Technology #133
Conversation
|
|
||
| @Override | ||
| public MariaDbDataSource createDataSource(Properties props) throws SQLException { | ||
| MariaDbDataSource source = new MariaDbDataSource(); |
There was a problem hiding this comment.
Implementation must distinguished basic implementation (MariaDbDataSource) and Connection pooling implementation (MariaDbPoolDataSource) if according properties JDBC_INITIAL_POOL_SIZE, JDBC_MAX_IDLE_TIME, JDBC_MAX_POOL_SIZE, JDBC_MAX_STATEMENTS, JDBC_MIN_POOL_SIZE, JDBC_PROPERTY_CYCLE are set
There was a problem hiding this comment.
One Problem I noticed: MariaDbPoolDataSource does not implements ConnectionPoolDataSource but DataSourceFactory#createConnectionPoolDataSource needs one.
On the other hand MariaDbDataSource DOES implement ConnectionPoolDataSource even though it seems it is not really one.
There was a problem hiding this comment.
Maybe it was meant that MariaDbPoolDataSource extends MariaDbDataSource and implements ConnectionPoolDataSource?
There was a problem hiding this comment.
Right, that has to be corrected in 2.5. Issue created: https://jira.mariadb.org/browse/CONJ-692
There was a problem hiding this comment.
So would it be possible to use the implementation as-is (even if not 100% correct in the sense of connection pooling) and change it when CONJ-692 is fixed?
| Dictionary<String, Object> properties = new Hashtable<>(); | ||
| properties.put(DataSourceFactory.OSGI_JDBC_DRIVER_CLASS, Driver.class.getName()); | ||
| properties.put(DataSourceFactory.OSGI_JDBC_DRIVER_NAME, "JDBC driver for MariaDB and MySQL"); | ||
| properties.put(DataSourceFactory.OSGI_JDBC_DRIVER_VERSION, Version.majorVersion + "." + Version.minorVersion); |
There was a problem hiding this comment.
Version.version would be better (like '2.4.1-SNAPSHOT', compare to '2.4' )
| public void start(BundleContext context) throws Exception { | ||
| Dictionary<String, Object> properties = new Hashtable<>(); | ||
| properties.put(DataSourceFactory.OSGI_JDBC_DRIVER_CLASS, Driver.class.getName()); | ||
| properties.put(DataSourceFactory.OSGI_JDBC_DRIVER_NAME, "JDBC driver for MariaDB and MySQL"); |
There was a problem hiding this comment.
This correspond to MariaDbDatabaseMetaData.DRIVER_NAME
There was a problem hiding this comment.
Thanks for the hint, I have changed this
|
How can we proceed on this? |
|
Hi, remains the point commented before and similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license. (The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/) Please indicate in a comment below that you are contributing your new code of the whole pull request under the BSD-new license or that you have filled out the contribution agreement and sent it. Thanks, |
|
I'm contributing the new code of the whole pull request under the BSD-new license, is there any template I need to add to the changed file? |
| <Import-Package> | ||
| javax.naming,javax.management,javax.net;resolution:=optional,javax.net.ssl;resolution:=optional,javax.sql,javax.transaction.xa;resolution:=optional,org.slf4j;resolution:=optional | ||
| </Import-Package> | ||
| <Import-Package>org.osgi.framework,javax.naming,javax.management,javax.net;resolution:=optional,javax.net.ssl;resolution:=optional,javax.sql,org.osgi.service.jdbc;resolution:=optional,javax.transaction.xa;resolution:=optional,org.slf4j;resolution:=optional</Import-Package> |
There was a problem hiding this comment.
I think you missed javax.security in this list. It prevents the driver from making SSL connections from an OSGi environment.
There was a problem hiding this comment.
I just added what was required for the jdbc service, if you think more packages are required I think you can simply open a new PR as this one is already closed.
|
@rusher I just noticed that it seems the code for supporting this OSGi specification was removed from maria-db is there a specific reason? Could it be added back again? |
Currently users are enforced to write their own code or using third party wrappers to use MariaDB together with OSGi JDBC/JPA Service,
This PR adds support for the OSGi Data Service Specification for JDBC™ Technology
This allows users of OSGi to use the MariaDB driver in a generic fashion. This is also a perquisite for using MariaDB together with the OSGi JPA Specification.
Since this part of the code is only activated inside an OSGi-Framework for all other users this change is completely transparent.