Add plugin support #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds MySQLServerCapabilities.PLUGIN_AUTH to the default capabilities of the client. Correctly decodes server announced capabilities by reading the second short value representing the high values. Parses out the plugin name from the server protocol. Correctly produces a MySQLClientAuthPacket based on server capabilities and extends this to potentially allow for other client authentication plugins in future.
|
Thanks, i will test that tomorrow when adding test cases |
|
closing this request, because your second request #22 is more complete (and merged!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MySQLServerCapabilities.PLUGIN_AUTH to the default capabilities of
the client.
Correctly decodes server announced capabilities by reading the second
short value representing the high values.
Parses out the plugin name from the server protocol.
Correctly produces a MySQLClientAuthPacket based on server capabilities
and extends this to potentially allow for other client authentication
plugins in future.