Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getTableTypes() returns "TABLE" consistent with getTables() #92

Merged
merged 1 commit into from Nov 24, 2016

Conversation

ConcreteGannet
Copy link
Contributor

In CONJ-218 (change 4e8c715), a table type of "BASE TABLE" is translated to "TABLE". The JDBC documentation describes "TABLE" as typical, so that's reasonable.
getTableTypes() returns the set of possible values for table types to be passed as a parameter to getTables() and to be expected in the results from getTables(). It should be modified to match, i.e. it should produce a value of "TABLE" and not "BASE TABLE".

In CONJ-218 (change 4e8c715), a table type of "BASE TABLE" is translated to "TABLE". The JDBC documentation describes "TABLE" as typical, so that's reasonable.
getTableTypes() returns the set of possible values for table types to be passed as a parameter to getTables() and to be expected in the results from getTables(). It should be modified to match, i.e. it should produce a value of "TABLE" and not "BASE TABLE".
@rusher
Copy link
Collaborator

rusher commented Nov 23, 2016

Hi ConcreteGannet,

Thanks for you contribution., as i say on CONJ-218, completely agree with you on this.

Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license. (The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/)

Please indicate in a comment below that you are contributing your new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license or that you have filled out the contribution agreement and sent it.

Thanks,
diego

@ConcreteGannet
Copy link
Contributor Author

I am contributing the whole pull request, including any new or modified files, under the BSD-new license.

@rusher rusher merged commit b81da5c into mariadb-corporation:master Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants