[misc] small performance enhancement to handle active connection counter

mariadb-corporation · May 31, 2022 · 94be5e8 · 94be5e8
1 parent e20e08b
commit 94be5e8
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/lib/pool.js b/lib/pool.js
@@ -119,7 +119,7 @@ class Pool extends EventEmitter {
 
   release(conn) {
     this._endLeak(conn);
-    delete this.#activeConnections[conn.threadId];
+    this.#activeConnections[conn.threadId] = undefined;
 
     conn.lastUse = Date.now();
     if (this.#closed) {
@@ -351,11 +351,16 @@ class Pool extends EventEmitter {
     let info = null;
     let conn = this.#idleConnections.get(0);
 
-    if (conn == null) {
-      conn = Object.keys(this.#activeConnections)[0];
+    if (!conn) {
+      for (const threadId in Object.keys(this.#activeConnections)) {
+        conn = this.#activeConnections[threadId];
+        if (!conn) {
+          break;
+        }
+      }
     }
 
-    if (conn != null) {
+    if (conn) {
       info = conn.info;
     }
     return info;
@@ -425,7 +430,11 @@ class Pool extends EventEmitter {
    * @return {number}
    */
   activeConnections() {
-    return Object.keys(this.#activeConnections).length;
+    let counter = 0;
+    for (const [key, value] of Object.entries(this.#activeConnections)) {
+      if (value) counter++;
+    }
+    return counter;
   }
 
   /**