Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force escapeId to emit backtick #101

Closed
scythx opened this issue Feb 8, 2020 · 3 comments
Closed

Force escapeId to emit backtick #101

scythx opened this issue Feb 8, 2020 · 3 comments

Comments

@scythx
Copy link

scythx commented Feb 8, 2020

Hello,

I've just encountered error in my sql because i have to as column name although i had escaped the name with escapeId. it turns out that escapeId only emit the backtick if satisfied by some criteria.

@ottok
Copy link

ottok commented Feb 8, 2020

Hello Raefaldhi!

You bug report is pretty much void of any actionable information. Please explain in detail what you tried to do, and what the result was, and what the expected result should have been.

Example reading: https://testlio.com/blog/the-ideal-bug-report/ and most importantly read https://github.com/mariadb-corporation/mariadb-connector-nodejs#contributing

@rusher
Copy link
Collaborator

rusher commented Feb 9, 2020

EscapeId implementation only use quote for identifiers that don't contain special characters.

Current implementation doesn't handle identifier that are reserved words, only ensure escaping.

That would make sense to always quote, to handle reserved words.

@rusher
Copy link
Collaborator

rusher commented Mar 20, 2020

released in 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants