Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoolConnection.release type appears to be incorrect #145

Closed
jamiehodge opened this issue Jan 14, 2021 · 1 comment
Closed

PoolConnection.release type appears to be incorrect #145

jamiehodge opened this issue Jan 14, 2021 · 1 comment

Comments

@jamiehodge
Copy link

PoolConnection.release is typed as () => void. Looking at the implementation, it appears to be () => Promise<void>.
rusher added a commit that referenced this issue Feb 1, 2021
@rusher
[CONJS-160] Wrong definition for typescript PoolConnection.release #145
9d88176
@rusher
Copy link
Collaborator

rusher commented Feb 16, 2021

release with latest release (2.5.3)

@rusher rusher closed this as completed Feb 16, 2021
@dependabot dependabot bot mentioned this issue Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamiehodge @rusher