Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Inconsistency default value of connectTimeout between docs and type comments #192

Closed
BC-M opened this issue Mar 14, 2022 · 1 comment

Comments

@BC-M
Copy link
Contributor

BC-M commented Mar 14, 2022

Found a mismatch between docs and type about the default value of connectTimeout.

Documentation says 1 seconds since v2.5.6:
https://github.com/mariadb-corporation/mariadb-connector-nodejs/blob/64ca753b7aa1a5d13e8e14799af5bda4271d5ce4/documentation/connection-options.md

Commend above Type says 10 seconds:

* The milliseconds before a timeout occurs during the initial connection to the MySQL server. (Default: 10 seconds)

@BC-M BC-M changed the title Docs: Inconsistency default value of connectionTimeout between docs and type comments Docs: Inconsistency default value of connectTimeout between docs and type comments Mar 14, 2022
@rusher
Copy link
Collaborator

rusher commented Mar 22, 2022

PR merged, so closing

@rusher rusher closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants