Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: supportBigNumbers & bigNumberStrings missing in ConnectionConfig #240

Closed
Nappsel opened this issue May 9, 2023 · 2 comments
Closed

Comments

@Nappsel
Copy link

Nappsel commented May 9, 2023

The ConnectConfig interface seems to be missing parameters supportBigNumbers and bigNumberStrings. According to the documentation they should be.

The following works, but is not covered by the TypeScript definition:

import { createConnection } from 'mariadb'

createConnection({
    host: '',
    database: '',
    user: '',
    password: '',
    supportBigNumbers: true,
  })
.then(() => {})
.catch(() => {});
@rusher
Copy link
Collaborator

rusher commented May 10, 2023

right, even if deprecated, they are missing in Typescript definition.

rusher added a commit that referenced this issue May 10, 2023
@rusher
Copy link
Collaborator

rusher commented May 31, 2023

Correction will be in 3.2.0 version

@Nappsel Nappsel closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants