Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to 2.0.4 could not find type definitions #49

Closed
nicgene opened this issue May 7, 2019 · 5 comments
Closed

Updated to 2.0.4 could not find type definitions #49

nicgene opened this issue May 7, 2019 · 5 comments

Comments

@nicgene
Copy link

nicgene commented May 7, 2019

I'm not able to find TypeScript definitions included with the NPM release.

Works if installed from the github repo.

@nicgene nicgene changed the title Updated to 2.0.4 could not find type declarations Updated to 2.0.4 could not find type definitions May 7, 2019
@knoxcard
Copy link
Contributor

knoxcard commented May 8, 2019

or you can use yarn

yarn add https://github.com/MariaDB/mariadb-connector-nodejs.git

@nicgene
Copy link
Author

nicgene commented May 8, 2019

Yup, that's how I installed it.

@rusher
Copy link
Collaborator

rusher commented May 9, 2019

reproduced.
The strange thing is that npm package doesn't have 'types/index.d.ts', that's what missing.
Package.json indicate to export this file :

 "files": [
    "lib",
    "types/index.d.js",
    "promise.js",
    "callback.js"
  ],

I must have missed something.
re-reading package.json definition

@rusher
Copy link
Collaborator

rusher commented May 9, 2019

ohh, "types/index.d.js", not "types/index.d.ts"
This will need a new release

@rusher
Copy link
Collaborator

rusher commented May 10, 2019

corrected with new 2.0.5 release

@rusher rusher closed this as completed May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants