Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change All Bigint Ref #143

Closed
wants to merge 3 commits into from
Closed

Change All Bigint Ref #143

wants to merge 3 commits into from

Conversation

keyurboss
Copy link

@keyurboss keyurboss commented Dec 30, 2020

While Compiling It with some old library like @ziet/ncc

(node:9454) UnhandledPromiseRejectionWarning: Error: Module parse failed: Identifier directly after number (669:86)

@rusher
Copy link
Collaborator

rusher commented Jan 11, 2021

This is normally not an issue, because node.js support bigint for all supported version (and if not supported, an error message is thrown).
Could you indicate the node.js version you are using ?

@keyurboss
Copy link
Author

it was not thrown by nodejs.

It was by webpack while compiling nodejs code to singal file.

Copy link
Collaborator

@rusher rusher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i didn't understand initial concern: Bigint literal are not supported by webpack.
So this changed can make sense. Tests are just to be corrected accordingly

test/integration/datatype/test-integer.js Outdated Show resolved Hide resolved
test/integration/datatype/test-integer.js Outdated Show resolved Hide resolved
test/integration/datatype/test-integer.js Outdated Show resolved Hide resolved
test/integration/datatype/test-integer.js Outdated Show resolved Hide resolved
@keyurboss keyurboss requested a review from rusher January 14, 2021 19:25
@rusher
Copy link
Collaborator

rusher commented Jan 18, 2021

Thanks for correcting test.
This is now merged in develop branch, and will be release in next 2.5.3 version

@rusher rusher closed this Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants