[fix] Handle LOCAL INFILE read errors #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utomatic recovery of the server.
Adds an error event listener to the LOCAL INFILE read stream to handle read errors generated midway through reading the file. Also removes the previous fs.access(...) check as there is a race condition between validating whether the file exists and is readable and actually trying to read it. If the file does not exist, is not readable, or some other error occurs while trying to read it then they will all be handled the same way.
Codecov Report
@@ Coverage Diff @@
## develop #56 +/- ##
==========================================
Coverage ? 95.96%
==========================================
Files ? 52
Lines ? 6266
Branches ? 0
==========================================
Hits ? 6013
Misses ? 253
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an error event listener to the LOCAL INFILE read stream to handle read errors generated midway through reading the file. Also removes the previous fs.access(...) check as there is a race condition between validating whether the file exists and is readable and actually trying to read it.
If the file does not exist, is not readable, or some other error occurs while trying to read it then they will all be handled the same way.
This should handle the situations described in https://jira.mariadb.org/browse/CONJS-79
I haven't included a test of an intermittent failure by mocking the error mid read (it's a bit more complicated than I have time for right now) but this changes passes all the existing LOCAL INFILE tests including the missing file ones.
Would be good for someone to spot check the return values and error situations as I'm not too familiar with the code base so inferred the error handling based on how it was handled in the previous async access check.