emit connection object on new connection #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusher
reviewed
Jun 17, 2019
lib/pool-base.js
Outdated
| @@ -379,7 +379,7 @@ function PoolBase(options, processTask, createConnectionPool, pingPromise) { | |||
| connectionInCreation = false; | |||
| idleConnections.push(conn); | |||
| pool.emit('idle-conn'); | |||
| pool.emit('new-conn'); | |||
| pool.emit('new-conn', conn); | |||
There was a problem hiding this comment.
Just a small improvement: better to use async event emiting then:
process.nextTick(() => pool.emit('new-conn', conn));
(and it will solve error in tests suite btw)
|
Nice addition btw. I'll merge after review correction is done. |
|
@rusher I also updated the documentation to reflect the changes, I hope that is ok. |
|
Nice, I'll merge that in develop branch. Regarding the mysql documentation, |
|
@rusher can you provide an approximate timeline for the release of 2.1.0? |
|
@mafischer soon. probably Thursday or Friday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coming from mysql, I really miss having the ability to set up session settings when a new connection becomes available.
https://github.com/mysqljs/mysql#connection
The only caveat is that the event name is
new-connwhereas in mysql it wasconnection. As long it's documented it's not a big deal.