Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing parameter for ordered selector #71

Merged

Conversation

kkx
Copy link

@kkx kkx commented Aug 24, 2019

Fix for this issue, added the missing parameter for following scenery:

  • using cluster pool
  • with ordered selector
  • first cluster down

it above case, the current code will cause an error as explained in the issue.

@codecov-io
Copy link

codecov-io commented Aug 24, 2019

Codecov Report

Merging #71 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #71      +/-   ##
=========================================
- Coverage   96.36%   96.2%   -0.16%     
=========================================
  Files          56      56              
  Lines        6939    6939              
=========================================
- Hits         6687    6676      -11     
- Misses        252     263      +11
Impacted Files Coverage Δ
lib/pool-cluster.js 96.64% <100%> (ø) ⬆️
lib/cmd/handshake/client-handshake-response.js 91.04% <0%> (-2.99%) ⬇️
lib/cmd/handshake/handshake.js 81.94% <0%> (-2.78%) ⬇️
lib/io/packet.js 92.17% <0%> (-2.18%) ⬇️
lib/cmd/handshake/initial-handshake.js 91.48% <0%> (-2.13%) ⬇️
lib/cmd/common-text-cmd.js 95.56% <0%> (-0.64%) ⬇️
lib/connection.js 94.73% <0%> (-0.21%) ⬇️
lib/pool-base.js 93.23% <0%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940bdbc...04452fc. Read the comment docs.

@rusher rusher merged commit 3f77b33 into mariadb-corporation:master Aug 29, 2019
@rusher
Copy link
Collaborator

rusher commented Aug 29, 2019

right. thanks for PR

@kkx
Copy link
Author

kkx commented Sep 4, 2019

Hi @rusher, i supose that this pr would be included in the next release, do you have any release plan for near future?

@rusher
Copy link
Collaborator

rusher commented Sep 4, 2019

Exactly, this will be part of the next release.
I cannot tell you the exact date still but will be released in the next 10 days, probably in the next few days

@kkx
Copy link
Author

kkx commented Sep 9, 2019

Exactly, this will be part of the next release.
I cannot tell you the exact date still but will be released in the next 10 days, probably in the next few days

Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants