Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleshed out the type definition for FieldInfo, for use in typeCast #76

Conversation

dacarley
Copy link

Fleshed out the type definition for FieldInfo, for use in typeCast callbacks.
Also removed an incorrect function definition for PoolCluster.add().

…llbacks.

Also removed an incorrect function definition for PoolCluster.add().
@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #76 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
- Coverage    96.35%   96.32%   -0.03%     
===========================================
  Files           56       56              
  Lines         6967     6967              
===========================================
- Hits          6713     6711       -2     
- Misses         254      256       +2
Impacted Files Coverage Δ
lib/pool-base.js 92.71% <0%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fce0b0...88fe793. Read the comment docs.

@dacarley
Copy link
Author

I wonder how the coverage number drops are possible, given that my changes don't impact any of the files with changed coverage?

@rusher
Copy link
Collaborator

rusher commented Sep 26, 2019

Great! merging soon.
About Codecov Report, I don't know at all. The goal was to indicate coverage, but those results don't make any sense.
I'll remove the plugin part on Github, keeping coverage test (it still helps to see part of code that is not or partially tested, even if all indicators are not to be completely trusted).

@rusher rusher merged commit bb7107c into mariadb-corporation:develop Sep 26, 2019
@dacarley dacarley deleted the features/typescript-typecast-types branch September 28, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants