Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix require of Errors in 2 files. #97

Merged
merged 1 commit into from Feb 4, 2020
Merged

Fix require of Errors in 2 files. #97

merged 1 commit into from Feb 4, 2020

Conversation

WayneMDB
Copy link
Contributor

Two files use Errors class without a require of misc/errors.js.

To see the issue in action:

const mariadb = require('mariadb');

const pool = mariadb.createPool({
    host: 'localhost',
    user: 'root',
    socketPath: '/run/mysqld/mysqld.sock',
});
var conn = pool.getConnection();
pool.end(); // Interrupts the pool get, which tries to throw an error and fails.

The node error:

(node:6656) UnhandledPromiseRejectionWarning: ReferenceError: Errors is not defined

@rusher rusher merged commit 47e12e8 into mariadb-corporation:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants