ODBC-311 Connector/ODBC libraries go to the wrong directories and it … #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuvova
suggested changes
May 14, 2021
abychko
force-pushed
the
master
branch
4 times, most recently
from
db7fbdd
to
9239796
Compare
…breaks packaging * enabled build with OpenSSL by default on UNIX * added deb and rpm variables to set the layout accordingly * added properly configured layout for rpm packages * added properly configured layout for deb packages it's not possible to hardcode all multiarch tuples on debian without GNUInstallDirs. so, only ia32 and amd64 are in place now, install layout is fixed and project can be built/tested on other systems (not deb and not rpm)
vuvova
reviewed
May 21, 2021
| SET(INSTALL_LIB_SUFFIX "lib" CACHE STRING "Directory, under which to install libraries, e.g. lib or lib64") | ||
| IF("${CMAKE_SIZEOF_VOID_P}" EQUAL "8" AND EXISTS "/usr/lib64/") | ||
| SET(INSTALL_LIB_SUFFIX "lib64") | ||
| ENDIF() |
There was a problem hiding this comment.
The link that Otto provided in ODBC-311, shows
-DINSTALL_LIBDIR=lib/$(DEB_HOST_MULTIARCH)/odbc
it seems to imply that libraries should go into /usr/lib/x86_64-linux-gnu/odbc and not into /usr/lib64/...
If it really is the Debian convention, you shouldn't do lib64 here for DEB
There was a problem hiding this comment.
it's moved from main CMakeLists.txt to install.cmake to set default bintar paths.
and there are duplicated variables for the same things, yes, but I didn't introduce them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…breaks packaging
it's not possible to hardcode all multiarch tuples on debian without
GNUInstallDirs. so, only ia32 and amd64 are in place
now, install layout is fixed and project can be built/tested on other systems
(not deb and not rpm). it's only install_layout, so it doesn't include cpack packaging