PR for odbc-359 as requested #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_WCHAR It is possible to pass a valid length buffer but no target buffer (and set BufferLength to 0) in SQLBindCol to get the length of that columns data but not actually copy it. To check if an error occurred the ptr was dereferenced without first checking if it points to a valid buffer which lead to a segfault.
lawrinn
reviewed
May 10, 2022
|
I am also unsure about where to put it, but info.c seems to be wrong location. blob.c even probably fits the best |
…/ only a length buffer
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This submission and all changes and additions are contributed under the new BSD license.
I was a bit unsure in what test file to put my new test case. If it doesn't fit where I put it please tell me and I'll move it.