CONPY-155: segmentation fault on calling connection.get_server_version()

Check if connection is still active and increment reference counter for server_version.
mariadb-corporation · Jun 6, 2021 · 9bb4e37 · 9bb4e37
1 parent b0235e8
commit 9bb4e37
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/mariadb/mariadb_connection.c b/mariadb/mariadb_connection.c
@@ -1388,6 +1388,8 @@ MrdbConnection_exit(MrdbConnection *self, PyObject *args __attribute__((unused))
 
 static PyObject *MrdbConnection_get_server_version(MrdbConnection *self)
 {
+  MARIADB_CHECK_CONNECTION(self, NULL);
+  Py_INCREF(self->server_version_info);
   return self->server_version_info;
 }
 

diff --git a/testing/test/integration/test_connection.py b/testing/test/integration/test_connection.py
@@ -190,5 +190,19 @@ def test_conpy101(self):
         c1 = mariadb.connect(**default_conf, autocommit=True)
         self.assertEqual(c1.autocommit, True)
 
+    def test_conpy155(self):
+        default_conf= conf()
+        c1 = mariadb.connect(**default_conf)
+        version= c1.get_server_version()
+        self.assertEqual(c1.get_server_version(), version)
+        self.assertEqual(c1.get_server_version(), version)
+        self.assertEqual(c1.get_server_version(), version)
+        self.assertEqual(c1.get_server_version(), version)
+        c1.close()
+        try:
+            version= c1.get_server_version()
+        except mariadb.InterfaceError:
+            pass
+
 if __name__ == '__main__':
     unittest.main()