Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client's backing LoopResources configurable via ConnectionFactoryOptions #21

Closed

Conversation

ks-yim
Copy link
Contributor

@ks-yim ks-yim commented Aug 22, 2021

Motivation:

Modifications:

  • Add loopResources property in MariadbConnectionFactoryConfiguration and run TcpClienton it.
  • Provide Option<LoopResources> to be parsed from ConnectionFactoryOptions and used to build MariadbConnectionFactoryConfiguration.

Please, feel free to close the PR or provide feedback if it doesn't fit into what the library is aiming at.

@rusher
Copy link
Collaborator

rusher commented Sep 8, 2021

Thanks for your contribution, this make sense. merged in branch 'maintenance/1.1.x'
btw, test issue for PR have been resolved with 064d5e0

@rusher rusher closed this Sep 8, 2021
@ks-yim ks-yim deleted the configurable-loop-resources branch September 10, 2021 01:46
@rusher
Copy link
Collaborator

rusher commented Sep 14, 2021

I've been too quick to merge contribution, similar to other open source projects, the MariaDB Corporation needs to have shared ownership of all code that is included. The easiest way to achieve this is by submitting your code under the BSD-new license.

Please indicate in a comment below that you are contributing your new code of the whole pull request, under the BSD-new license.

@ks-yim
Copy link
Contributor Author

ks-yim commented Sep 16, 2021

@rusher
I hereby agree to contribute the whole code of this pull request under BSD-new license.

@rusher
Copy link
Collaborator

rusher commented Sep 16, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants