Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update studio-macos.sh #48

Merged
merged 1 commit into from Apr 4, 2020
Merged

Update studio-macos.sh #48

merged 1 commit into from Apr 4, 2020

Conversation

hteumeuleu
Copy link
Contributor

@hteumeuleu hteumeuleu commented Apr 4, 2020

This change aims to make the app a tiny bit more user friendly to run on macOS by simply being able to run the studio-macos.sh file from the Finder (or from a shortcut on the Dock for example).

Currently, running the studio-macos.sh script from anywhere outside the STUdio folder outputs the following errors:

cp: ./agent/studio-agent-0.1.11-jar-with-dependencies.jar: No such file or directory
cp: ./agent/studio-metadata-0.1.11-jar-with-dependencies.jar: No such file or directory
Error: Could not find or load main class io.vertx.core.Launcher
Caused by: java.lang.ClassNotFoundException: io.vertx.core.Launcher
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

Prefixing the problematic paths by the executable path fixes the problem.

This change aims to make the app a tiny bit more user friendly to run on macOS by simply being able to run the `studio-macos.sh` file from the Finder (or from a shortcut on the Dock for example).

Currently, running the `studio-macos.sh` script from anywhere outside the STUdio folder outputs the following errors:

```console
cp: ./agent/studio-agent-0.1.11-jar-with-dependencies.jar: No such file or directory
cp: ./agent/studio-metadata-0.1.11-jar-with-dependencies.jar: No such file or directory
Error: Could not find or load main class io.vertx.core.Launcher
Caused by: java.lang.ClassNotFoundException: io.vertx.core.Launcher
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
```

Prefixing the problematic paths by the executable path fixes the problem.
@marian-m12l
Copy link
Owner

@marian-m12l marian-m12l commented Apr 4, 2020

Great contribution!
I'll update the linux and windows scripts to match this.

@marian-m12l marian-m12l merged commit ba2fb2e into marian-m12l:master Apr 4, 2020
@xavbart
Copy link

@xavbart xavbart commented Jun 25, 2020

Just a note : if a shell script is suffixed with .command instead of .sh (and has the executable permissions -chmod 755-, and is allowed to run in Security Systems preferences) it can simply be run on double click (it will be passed to a terminal window). But indeed it will stil need the proper paths.

@marian-m12l
Copy link
Owner

@marian-m12l marian-m12l commented Jun 26, 2020

@xavbart Thanks for the info. However I'm hoping to move away from those launch scripts in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants