Show the Namespace in failure message #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to hold off on this until after 1.5 is released. I'd like to see this as a configuration option, and I think the whole "where is the failure from" issue could maybe use some rethinking. |
|
Sounds good, I'll look more into the configuration option |
By default off
This means we have the same behaviour as previous versions but we can tweak that option if we want it.
|
I've add a config option which defaults to off so as to replicate the existing Midje behaviour. |
|
Thanks |
marick
added a commit
that referenced
this pull request
Feb 21, 2013
Show the Namespace in failure message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failures now contain the namespace of the test.
FAIL at (firm_check_failures.clj:9 implementation.firm-check-failures)Relating to issue: #178