Permalink
Commits on Aug 21, 2012
  1. merged branch bdmu/ticket_5233 (PR #5234)

    Commits
    -------
    
    47b8538 [Filesystem] missing realpath breaking FilesystemTest class on Windows (one line of code change)
    
    Discussion
    ----------
    
    [Filesystem] missing readlink breaking FilesystemTest class on Windows
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #5233
    Todo:
    License of the code: MIT
    Documentation PR:
    
    fix for windows plateform
    
    $file == 'C:\Users\USERNA~1\...' before touch
    $file == 'C:\Users\Username\... after the touch and readlink so it can pass following assertEquals
    
    ---------------------------------------------------------------------------
    
    by bdmu at 2012-08-13T05:35:07Z
    
    Hello,
    
    Another solution may be (need to test it) to add
        $this->workspace = realpath($this->workspace);
    line 36, after the
        mkdir($this->workspace, 0777, true);
    in the setup method
    
    Regards,
    Christophe
    fabpot committed Aug 21, 2012
Commits on Aug 19, 2012
  1. merged branch Partugal/patch-guesser-perfomance (PR #5298)

    Commits
    -------
    
    630d16b small optimization
    
    Discussion
    ----------
    
    [Form] Guesser perfomance
    
    speedup depends on count of guesses
    on my tests is 2,4 and 6 x faster for 5, 10 and 20 guesses
    fabpot committed Aug 19, 2012
Commits on Aug 18, 2012
  1. small optimization

    linniksa committed Aug 18, 2012
  2. merged branch mtdowling/event_dispatcher_add_iterator (PR #5268)

    Commits
    -------
    
    0ad00f8 [EventDispatcher] Adding IteratorAggregate to GenericEvent
    
    Discussion
    ----------
    
    [EventDispatcher] Adding IteratorAggregate to GenericEvent
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-08-16T07:43:29Z
    
    What is the use case for this that it should be part of the Generic event?
    
    ---------------------------------------------------------------------------
    
    by mtdowling at 2012-08-16T17:12:28Z
    
    This allows for the GenericEvent to be even more generic. Now listeners don't need to know an exact key from the arguments, but rather can iterate over the arguments to find what they are looking for. This makes the GenericEvent more like an array.
    
    ---------------------------------------------------------------------------
    
    by mtdowling at 2012-08-17T19:31:04Z
    
    How would this be a nasty break? It's just giving the GenericEvent more capabilities with IteratorAggregate.
    
    This is a completely separate PR from the one that flipped the constructor args.
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2012-08-17T19:34:47Z
    
    Why are you not just doing ``foreach ($event->getArguments() as $arg) { /** ... */ }``?
    
    If you just have ``foreach ($event)``, to me at least it would not be so clear what we are actually iterating over.
    
    ---------------------------------------------------------------------------
    
    by mtdowling at 2012-08-17T19:39:23Z
    
    This class already has ArrayAccess. If you're already using this class like an array, then I think you should expect to be able to iterate it like an array. I'm just finishing that concept off by implementing IteratorAggregate.
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2012-08-17T19:47:43Z
    
    Indeed, if we already have ArrayAccess which we probably don't want to remove again, then that seems reasonable.
    fabpot committed Aug 18, 2012
  3. merged branch Marmelatze/var_dump (PR #5291)

    Commits
    -------
    
    9c20634 fixes pre for var_dump with xdebug
    
    Discussion
    ----------
    
    Displaying var_dump with xdebug in exceptions
    
    When debugging code I often use `var_dump` to quickly look into variables. Since 2.1 alle output generated by `var_dump` is displayed in one line. http://screencast.com/t/11LuIlIdHsvP
    It seems to be no problem for small objects, but it becomes a real pain when displaying huge arrays or objects.
    
    This is caused by the changed word-wrapping for the pre tag introduced in #3827
    
    With fix: http://screencast.com/t/GdA3dkpWxU
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-08-17T17:22:38Z
    
    👍
    fabpot committed Aug 18, 2012
  4. merged branch drak/nullhandler (PR #5290)

    Commits
    -------
    
    8e11aaa [FrameworkBundle] Allow to set null for the handler in NativeSessionStorage
    
    Discussion
    ----------
    
    [FrameworkBundle] Allow to set null for the handler in NativeSessionStorage
    
    Bug fix: no
    Feature addition: yes (ok for RC)
    Backwards compatibility break: yes
    Symfony2 tests pass: yes
    Fixes the following tickets: 5267
    Todo: ~
    License of the code: MIT
    Documentation PR: ~
    
    Refs #5267
    
    Adds the following configuration
    
    ```
    session:
            handler_id: ~
    ```
    
    Which allows the configuration of the session not to use any save handler and therefor just use whatever save_handler is set in `php.ini`
    
    ---------------------------------------------------------------------------
    
    by dlsniper at 2012-08-17T17:24:37Z
    
    👍
    fabpot committed Aug 18, 2012
Commits on Aug 17, 2012
  1. merged branch bamarni/patch-5 (PR #5285)

    Commits
    -------
    
    bd9319b added a missing phpdoc param
    
    Discussion
    ----------
    
    added a missing phpdoc param
    fabpot committed Aug 17, 2012
  2. added a missing phpdoc param

    bamarni committed Aug 17, 2012
  3. merged branch Tobion/headerbag (PR #5282)

    Commits
    -------
    
    ccb6dad [HttpFoundation] fixed undefined offset for assoc arrays in HeaderBag
    
    Discussion
    ----------
    
    [HttpFoundation] fixed undefined offset for assoc arrays in HeaderBag
    
    `get` is assuming the headers are zero-indexed. So something like this would otherwise create a php warning.
    ```
    $bag->set('foo', array('bad-assoc-index' => 'value'));
    $this->assertSame('value', $bag->get('foo'));
    ```
    fabpot committed Aug 17, 2012
  4. merged branch Tobion/patch-3 (PR #5276)

    Commits
    -------
    
    bdaa877 [HttpFoundation] fix #5271 (duplicated header in JsonResponse)
    
    Discussion
    ----------
    
    fix JsonResponse: duplicate header
    
    fix #5271
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-16T16:50:04Z
    
    Will look into the failing test later.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-16T23:55:45Z
    
    Finished.
    fabpot committed Aug 17, 2012
Commits on Aug 16, 2012
  1. fixed typos in the UPGRADE file

    fabpot committed Aug 16, 2012
  2. merged branch TomAdam/pr-choice-bc-doc (PR #5263)

    Commits
    -------
    
    9e3e589 Alter upgrade notes with changes to _form_is_choice_selected twig function
    
    Discussion
    ----------
    
    Undocumented BC break - choice field type template
    
    The upgrade notes for the choice field template are out of date. They currently state:
    
    ```
    The `choices` variable now contains `ChoiceView` objects with two getters,
    getValue() and getLabel(), to access the choice data.
    ```
    
    However these methods do not exist. I assume this is the result of a rollback to maintain BC?
    
    In addition to this, the `_form_is_choice_selected` twig function has been removed and replaced with a filter called `selectedchoice`. This is an undocumented BC break. I have attached an update to the notes to reflect these changes.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-15T17:20:35Z
    
    ping @bschussek
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-16T17:36:22Z
    
    Looks good apart from my comment. Thanks for fixing this!
    fabpot committed Aug 16, 2012
  3. merged branch bschussek/issue5144 (PR #5278)

    Commits
    -------
    
    0add23f [Form] Reintroduced the option "invalid_message_parameters"
    
    Discussion
    ----------
    
    [Form] Reintroduced the option "invalid_message_parameters"
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #5144
    Todo: -
    fabpot committed Aug 16, 2012
  4. merged branch bschussek/issue5205 (PR #5277)

    Commits
    -------
    
    3ad3876 [Form] Fixed support for preferred choices in "entity" type
    
    Discussion
    ----------
    
    [Form] Fixed support for preferred choices in "entity" type
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #5205
    Todo: -
    fabpot committed Aug 16, 2012
  5. fixed typo in the UPGRADE file

    fabpot committed Aug 16, 2012
  6. merged branch fixe/patch-7 (PR #5272)

    Commits
    -------
    
    4b5adcd Typo in UPGRADE-2.1
    
    Discussion
    ----------
    
    Typo in UPGRADE-2.1
    fabpot committed Aug 16, 2012
  7. Typo in UPGRADE-2.1

    fixe committed Aug 16, 2012
Commits on Aug 15, 2012
  1. merged branch guilhermeblanco/redis_support (PR #5224)

    Commits
    -------
    
    493aa12 Added support to redis, wincache and zend data cache.
    
    Discussion
    ----------
    
    Added support to redis, wincache and zend data cache.
    
    These three drivers were missing support on DoctrineBundle.
    
    DoctrineBundle PR doctrine/DoctrineBundle#99 must be merged first
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-09T20:35:21Z
    
    This looks good to me
    fabpot committed Aug 15, 2012
  2. merged branch gimler/patch-3 (PR #5256)

    Commits
    -------
    
    a7b4573 add format to exception message
    
    Discussion
    ----------
    
    add format to exception message
    fabpot committed Aug 15, 2012
  3. merged branch myurasov/patch-1 (PR #5261)

    Commits
    -------
    
    ac0fb48 0x02 -> \MongoBinData::BYTE_ARRAY
    70a64bd MongoBinData constructor now require "type" parameter
    
    Discussion
    ----------
    
    MongoBinData constructor now requires "type" parameter
    
    From mongo driver version 1.2.11 E_DEPRECATED is emitted when the 2nd argument (type) is not used for MongoBinData constructor. At the moment the default value is 0x02 ("byte array").
    
    See: http://php.net/manual/en/mongobindata.construct.php
    fabpot committed Aug 15, 2012
  4. merged branch ruian/patch-1 (PR #5265)

    Commits
    -------
    
    524081f fix CS into Finder
    
    Discussion
    ----------
    
    fix CS into Finder
    
    fix CS into Finder
    fabpot committed Aug 15, 2012
  5. fix CS into Finder

    fix CS into Finder
    ruian committed Aug 15, 2012
Commits on Aug 14, 2012
  1. MongoBinData constructor now require "type" parameter

    From mongo driver version 1.2.11 E_DEPRECATED is emitted when the 2nd argument (type) is not used for MongoBinData constructor. At the moment the default value is 0x02 ("byte array").
    
    See: http://php.net/manual/en/mongobindata.construct.php
    myurasov committed Aug 14, 2012
  2. Revert "merged branch guilhermeblanco/patch-6 (PR #4456)"

    This reverts commit 6c527b6, reversing
    changes made to 223d187.
    fabpot committed Aug 14, 2012
  3. add format to exception message

    gimler committed Aug 14, 2012
Commits on Aug 13, 2012
  1. merged branch daFish/fixes/issue5108 (PR #5247)

    Commits
    -------
    
    57694aa Removed MySQL-exclusive usage of unsigned integer from table creation
    
    Discussion
    ----------
    
    [Security] Removed MySQL-exclusive usage of unsigned integer from table creation
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #5108
    
    This patch removes the setting of unsigned integer fields which are MySQL-only.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-13T12:25:23Z
    
    @beberlei Does it look good?
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-08-13T12:30:27Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2107738) (merged 57694aa into 31536c3).
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2012-08-13T20:04:20Z
    
    indeed afaik unsigned isnt part of the sql standard. in other RDBMS you need to use a constraint if you want to prevent negative values and of course there is no way to then also get the additional values per bit that you get with MySQL, but so it goes. that being said .. i dont know how Doctrine schema handles unsigned for other RDBMS .. ie if it just emulates them by trying to double the size with a constraint.
    
    ---------------------------------------------------------------------------
    
    by beberlei at 2012-08-13T20:10:44Z
    
    Looks good.
    
    Doctrine ignores the 'unsigned' => true for all others vendors.
    fabpot committed Aug 13, 2012